DrakiaXYZ/SPT-AKI-Installer
0
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix version check not handling preview versions

Browse Source
This commit is contained in:
IsWaffle 2023-08-28 11:05:00 -04:00
parent 67fcab23b1
commit 73b149779d
3 changed files with 21 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
SPTInstaller/Installer Tasks/PreChecks/NetCore6PreCheck.cs
View File

@ -1,5 +1,7 @@
using SPTInstaller.Models; using Serilog;
using SPTInstaller.Models;
using System.Diagnostics; using System.Diagnostics;
using System.Text.RegularExpressions;
using System.Threading.Tasks; using System.Threading.Tasks;
namespace SPTInstaller.Installer_Tasks.PreChecks; namespace SPTInstaller.Installer_Tasks.PreChecks;
@ -44,7 +46,7 @@ public class NetCore6PreCheck : PreCheckBase
} }
catch (Exception ex) catch (Exception ex)
{ {
// TODO: logging Log.Error(ex, $"PreCheck::{Name}::Exception");
return PreCheckResult.FromException(ex); return PreCheckResult.FromException(ex);
} }
@ -52,20 +54,21 @@ public class NetCore6PreCheck : PreCheckBase
foreach (var lineVersion in output) foreach (var lineVersion in output)
{ {
if (lineVersion.StartsWith("Microsoft.WindowsDesktop.App") && lineVersion.Split(" ").Length > 1) var regex = Regex.Match(lineVersion, @"Microsoft.WindowsDesktop.App (\d\.\d\.\d)");
if (!regex.Success || regex.Groups.Count < 1)
continue;
var stringVersion = regex.Groups[1].Value;
var foundVersion = new Version(stringVersion);
if (foundVersion >= minRequiredVersion)
{ {
string stringVerion = lineVersion.Split(" ")[1]; return PreCheckResult.FromSuccess($".Net Core {minRequiredVersion} Desktop Runtime or higher is installed.\n\nInstalled Version: {foundVersion}");
var foundVersion = new Version(stringVerion);
// waffle: not fully sure if we should only check for 6.x.x versions or if higher major versions are ok
if (foundVersion >= minRequiredVersion)
{
return PreCheckResult.FromSuccess($".Net Core {minRequiredVersion} Desktop Runtime or higher is installed.\n\nInstalled Version: {foundVersion}");
}
highestFoundVersion = foundVersion > highestFoundVersion ? foundVersion : highestFoundVersion;
} }
highestFoundVersion = foundVersion > highestFoundVersion ? foundVersion : highestFoundVersion;
} }
return PreCheckResult.FromError($".Net Core Desktop Runtime version {minRequiredVersion} or higher is required.\n\nHighest Version Found: {(highestFoundVersion > new Version("0.0.0") ? highestFoundVersion : "Not Found")}\n\nThis is required to play SPT, but you can install it later if and shouldn't affect the SPT install process.", failedButtonText, failedButtonAction); return PreCheckResult.FromError($".Net Core Desktop Runtime version {minRequiredVersion} or higher is required.\n\nHighest Version Found: {(highestFoundVersion > new Version("0.0.0") ? highestFoundVersion : "Not Found")}\n\nThis is required to play SPT, but you can install it later if and shouldn't affect the SPT install process.", failedButtonText, failedButtonAction);

4
SPTInstaller/Installer Tasks/PreChecks/NetFramework472PreCheck.cs
View File

@ -1,4 +1,5 @@
using Microsoft.Win32; using Microsoft.Win32;
using Serilog;
using SPTInstaller.Models; using SPTInstaller.Models;
using System.Diagnostics; using System.Diagnostics;
using System.Threading.Tasks; using System.Threading.Tasks;
@ -55,8 +56,7 @@ public class NetFramework472PreCheck : PreCheckBase
} }
catch (Exception ex) catch (Exception ex)
{ {
// TODO: log exceptions Log.Error(ex, $"PreCheck::{Name}::Exception");
return PreCheckResult.FromException(ex); return PreCheckResult.FromException(ex);
} }
} }

4
SPTInstaller/SPTInstaller.csproj
View File

@ -9,8 +9,8 @@
<PackageIcon>icon.ico</PackageIcon> <PackageIcon>icon.ico</PackageIcon>
<ApplicationIcon>Assets\icon.ico</ApplicationIcon> <ApplicationIcon>Assets\icon.ico</ApplicationIcon>
<Configurations>Debug;Release;TEST</Configurations> <Configurations>Debug;Release;TEST</Configurations>
<AssemblyVersion>2.10</AssemblyVersion> <AssemblyVersion>2.11</AssemblyVersion>
<FileVersion>2.10</FileVersion> <FileVersion>2.11</FileVersion>
</PropertyGroup> </PropertyGroup>
<ItemGroup> <ItemGroup>