From 7549f164aec9ae85fe2378f1d20ab746642bc8d6 Mon Sep 17 00:00:00 2001
From: Rev <revaxl09@gmail.com>
Date: Mon, 11 Oct 2021 16:00:49 +0900
Subject: [PATCH] return 204 response if search has empty result

---
 app/Http/Controllers/ItemController.php | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/app/Http/Controllers/ItemController.php b/app/Http/Controllers/ItemController.php
index 76c6061..8a54412 100644
--- a/app/Http/Controllers/ItemController.php
+++ b/app/Http/Controllers/ItemController.php
@@ -27,9 +27,16 @@ class ItemController extends Controller
      */
     public function search(Request $request): JsonResponse
     {
-        return response()->json([
-            'item' => $this->itemsCollection->findItem($request->input('query')),
-        ]);
+        $status = Response::HTTP_NO_CONTENT;
+        $result = $this->itemsCollection->findItem($request->input('query'));
+        $response = [];
+        if ($result->isNotEmpty()) {
+            $status = Response::HTTP_OK;
+            $response = [
+                'items' => $result->toArray(),
+            ];
+        }
+        return response()->json($response, $status);
     }
 
     /**