From 7cdd4645bdf671d38c3d9a1597d1d4b911fe5a82 Mon Sep 17 00:00:00 2001
From: Rev <revaxl09@gmail.com>
Date: Sun, 10 Oct 2021 13:10:35 +0900
Subject: [PATCH] wrap get item with try catch

---
 app/Http/Controllers/ItemController.php | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

diff --git a/app/Http/Controllers/ItemController.php b/app/Http/Controllers/ItemController.php
index 2645956..80f7a69 100644
--- a/app/Http/Controllers/ItemController.php
+++ b/app/Http/Controllers/ItemController.php
@@ -5,6 +5,9 @@ namespace App\Http\Controllers;
 use App\Data\ItemsCollection;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
+use Illuminate\Http\Response;
+use Illuminate\Support\Facades\Log;
+use Throwable;
 
 class ItemController extends Controller
 {
@@ -35,8 +38,16 @@ class ItemController extends Controller
      */
     public function getItem(string $id): JsonResponse
     {
-        return response()->json([
-            'item' => $this->itemsCollection->getItemById($id),
-        ]);
+        try {
+            return response()->json([
+                'item' => $this->itemsCollection->getItemById($id),
+            ]);
+        } catch (Throwable $exception) {
+            Log::error($exception->getMessage());
+            Log::error($exception->getTraceAsString());
+            return response()->json([
+                'item' => [],
+            ], Response::HTTP_NOT_FOUND);
+        }
     }
 }