From 916f3836188002c04c32adf1d4a3abaf56687f89 Mon Sep 17 00:00:00 2001 From: Mangiang Date: Tue, 12 Oct 2021 00:40:07 -0400 Subject: [PATCH] refacto: Refactor search endpoint --- app/Http/Controllers/ItemController.php | 5 ++--- routes/web.php | 4 ++-- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/app/Http/Controllers/ItemController.php b/app/Http/Controllers/ItemController.php index 454aa97..14f1bce 100644 --- a/app/Http/Controllers/ItemController.php +++ b/app/Http/Controllers/ItemController.php @@ -23,13 +23,12 @@ class ItemController extends Controller /** * @param Request $request - * @param string $locale * @return JsonResponse */ - public function search(Request $request, string $locale = 'en'): JsonResponse + public function search(Request $request): JsonResponse { $status = Response::HTTP_NO_CONTENT; - $result = $this->itemsCollection->findItem($request->input('query'), $locale); + $result = $this->itemsCollection->findItem($request->input('query'), $request->input('locale') ?? 'en'); $response = []; if ($result->isNotEmpty()) { $status = Response::HTTP_OK; diff --git a/routes/web.php b/routes/web.php index dab903c..a746fc6 100644 --- a/routes/web.php +++ b/routes/web.php @@ -19,8 +19,8 @@ $router->get('/', function () { $router->get('/api/locales', 'ItemController@getLocales'); $router->get('/api/refresh', 'ItemController@refreshAllCache'); +$router->post('/api/search', 'ItemController@search'); $router->get('/api/item/{id}/{locale}', 'ItemController@getItem'); $router->get('/api/item/{id}', 'ItemController@getItem'); -$router->post('/api/search/{locale}', 'ItemController@search'); -$router->post('/api/search', 'ItemController@search'); +