Terkoiz/Freecam
Archived
0
0
Fork 1
Code Issues Pull Requests Projects Releases 16 Wiki Activity

Fix and add features #3

Merged
Terkoiz merged 3 commits from CWX/Freecam:master into master 2023-02-21 12:04:57 -05:00
Conversation 1 Commits 3 Files Changed 10 +172 -258
CWX commented 2023-02-18 15:33:45 -05:00
Contributor
Copy Link

Features:
Add toggle for Fall damage,
Restructure to add sln
Change design to attach to gameworld on Raid start,
implement Destroys.

Fix:
Fix un-needed Dependencies,
Fix bug with on raid end whilst in freecam,
Fix FreeCam script calculations to be faster (jetbrains says so :))

Changes:
Changed to disable GamePlayerOwner instead of Detours,
Changed GitIgnore as im a Rider pleb now,
Init Camera, script and getting gamePlayerOwner to the start of the script,
Change method of getting Player.

Features: Add toggle for Fall damage, Restructure to add sln Change design to attach to gameworld on Raid start, implement Destroys. Fix: Fix un-needed Dependencies, Fix bug with on raid end whilst in freecam, Fix FreeCam script calculations to be faster (jetbrains says so :)) Changes: Changed to disable GamePlayerOwner instead of Detours, Changed GitIgnore as im a Rider pleb now, Init Camera, script and getting gamePlayerOwner to the start of the script, Change method of getting Player.
CWX added 1 commit 2023-02-18 15:33:45 -05:00
Terkoiz requested changes 2023-02-18 15:59:08 -05:00
project/Terkoiz.Freecam/FreecamController.cs
@ -242,56 +220,18 @@ namespace Terkoiz.Freecam
{
// If the GameWorld instance is null or has no RegisteredPlayers, it most likely means we're not in a raid
Terkoiz commented 2023-02-18 15:58:10 -05:00
Owner

Update the comments if you change the related code

Update the comments if you change the related code
CWX commented 2023-02-18 16:35:54 -05:00
Author
Contributor

changed

changed
Terkoiz marked this conversation as resolved
project/Terkoiz.Freecam/FreecamController.cs Outdated
@ -247,4 +224,3 @@
return null;
}
// One of the RegisteredPlayers will have the IsYourPlayer flag set, which will be our own Player instance
Terkoiz commented 2023-02-18 15:58:23 -05:00
Owner

Same comment as above

Same comment as above
CWX commented 2023-02-18 16:36:14 -05:00
Author
Contributor

removed as i didnt think it was needed

removed as i didnt think it was needed
Terkoiz marked this conversation as resolved
project/Terkoiz.Freecam/FreecamPatch.cs Outdated
@ -0,0 +21,4 @@
return;
// Add FreeCamController to GameWorld GameObject
gameworld.GetOrAddComponent<FreecamController>();
Terkoiz commented 2023-02-18 15:55:37 -05:00
Owner

Sam says:

If you want multiversion compatibility, you shouldn't use GetOrAddComponent as this is eft GClassXX extension method, which means compiler will transfer it into GClass call that will change at some point and the mod will need to be recompiled with changed assembly-csharp in references

Sam says: > If you want multiversion compatibility, you shouldn't use GetOrAddComponent as this is eft GClassXX extension method, which means compiler will transfer it into GClass call that will change at some point and the mod will need to be recompiled with changed assembly-csharp in references
CWX commented 2023-02-18 16:36:42 -05:00
Author
Contributor

changed to gameworld.GameObject.AddComponent instead

changed to gameworld.GameObject.AddComponent instead
Terkoiz marked this conversation as resolved
project/Terkoiz.Freecam/FreecamPlugin.cs
@ -127,0 +123,4 @@
TogglesSectionName,
"FallHeightToggle",
true,
"True disables fall damage, False doesn't simplez");
Terkoiz commented 2023-02-18 15:53:43 -05:00
Owner

Change the description to be more consistent with others, ex: If enabled, will disable all fall damage for the player.

Change the description to be more consistent with others, ex: `If enabled, will disable all fall damage for the player.`
CWX commented 2023-02-18 16:36:49 -05:00
Author
Contributor

done

done
Terkoiz marked this conversation as resolved
project/Terkoiz.Freecam/Properties/AssemblyInfo.cs Outdated
@ -5,4 +0,0 @@
// General Information about an assembly is controlled through the following
// set of attributes. Change these attribute values to modify the information
// associated with an assembly.
[assembly: AssemblyTitle("Terkoiz.Freecam")]
Terkoiz commented 2023-02-18 15:54:42 -05:00
Owner

Missing assembly info replacements for the remade project. Yes, I'm that autistic.

Missing assembly info replacements for the remade project. Yes, I'm that autistic.
CWX commented 2023-02-18 16:37:06 -05:00
Author
Contributor

added it, Shrug to what it does tho

added it, Shrug to what it does tho
Terkoiz marked this conversation as resolved
CWX added 1 commit 2023-02-18 16:35:24 -05:00
CWX requested review from Terkoiz 2023-02-18 16:38:04 -05:00
CWX added 1 commit 2023-02-18 17:13:42 -05:00
Terkoiz merged commit 9801f92d69 into master 2023-02-21 12:04:57 -05:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No Reviewers
Terkoiz
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Terkoiz/Freecam#3
No description provided.
Delete Branch "CWX/Freecam:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?