archon0ne/sptMO2
archon0ne/sptMO2
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases 1 Wiki Activity

Support new method of feature registration #1

Merged
archon0ne merged 1 commits from :main into main 2024-09-23 06:39:27 -04:00
Conversation 1 Commits 1 Files Changed 1 +4 -1
Gipphe commented 2024-09-17 17:38:46 -04:00
Contributor
Copy Link

Starting with Mod Organizer 2.5.1, the _featureMap dict has been removed in lieu of the _register_feature method.

This PR's changes attempt to support both methods of registering features, allowing this plugin to be used on both Mod Organizer 2.5.1 and later, as well as versions prior to 2.5.1.

I've tested this change locally, and it works as expected on my machine, at the very least.

I am aware that it might seem odd, or even a bit rude, for me to just open a PR right off the bat like this, but this fix was so simple that I thought it didn't warrant much discussion, to be frank.

Starting with Mod Organizer 2.5.1, [the `_featureMap` dict has been removed in lieu of the `_register_feature` method](https://github.com/ModOrganizer2/modorganizer-basic_games/commit/71dbb8c557d43cba9d290674a332e7ecd1650261#diff-6bb098ee284f5eaeebac374aea76f991a5f64ec0d315558bd0a7bbd3fb796c67). This PR's changes attempt to support both methods of registering features, allowing this plugin to be used on both Mod Organizer 2.5.1 and later, as well as versions prior to 2.5.1. I've tested this change locally, and it works as expected on my machine, at the very least. I am aware that it might seem odd, or even a bit rude, for me to just open a PR right off the bat like this, but this fix was so simple that I thought it didn't warrant much discussion, to be frank.
Gipphe added 1 commit 2024-09-17 17:38:47 -04:00
archon0ne commented 2024-09-23 06:37:22 -04:00
Owner
Copy Link

Did not see this until today. Thanks for the patch, will be sure to update the spt page with it.

And no, not rude at all, very welcome in fact. 🫡

Did not see this until today. Thanks for the patch, will be sure to update the spt page with it. And no, not rude at all, very welcome in fact. 🫡
🚀 1
archon0ne merged commit 6c2ecb2afd into main 2024-09-23 06:39:27 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
archon0ne
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: archon0ne/sptMO2#1
No description provided.
Delete Branch ":main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?