chomp/BotGenerator
0
0
Fork 1
Code Issues Pull Requests Projects Releases Wiki Activity

Minor Changes to Resolve Warnings #5

Merged
chomp merged 4 commits from warnings into master 2024-11-14 15:03:42 -05:00
Conversation 0 Commits 4 Files Changed 3 +47 -25
Refringe commented 2024-11-14 13:13:34 -05:00
Contributor
Copy Link

Resolves a number of CS0109, HAA060, and HAA0401 warnings. See commits for details.

Resolves a number of CS0109, HAA060, and HAA0401 warnings. See commits for details.
Refringe added 4 commits 2024-11-14 13:13:35 -05:00 
A class declaration included the new keyword even though the declaration does not override an existing declaration in a base class. The new keyword can be deleted.
Value type to reference type conversion causes boxing at call site, and unboxing at the callee-site. Resolves by explicitly converting value to string before including it in a log message string.
- Reduce LINQ overhead by replacing SingleOrDefault and filtering logic with manual iteration.
- Use HashSet and case-insensitive comparisons for faster lookups.

Both of these changes resolve a number of HAA0401 warnings:
Possible allocation of reference type enumerator; non-ValueType enumerator may result in a heap allocation.
.NET 9
Newtonsoft.Json v13.0.3
chomp merged commit 294881dcca into master 2024-11-14 15:03:42 -05:00
chomp deleted branch warnings 2024-11-14 15:03:42 -05:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: chomp/BotGenerator#5
No description provided.
Delete Branch "warnings"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?