From 58e8adb73053d6b6480dccafbe9fb5464a75a6ac Mon Sep 17 00:00:00 2001 From: Refringe Date: Fri, 13 Sep 2024 00:17:13 -0400 Subject: [PATCH] Adds TODO for query. --- app/Http/Filters/ModFilter.php | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/app/Http/Filters/ModFilter.php b/app/Http/Filters/ModFilter.php index b4ca066..bd1ecf6 100644 --- a/app/Http/Filters/ModFilter.php +++ b/app/Http/Filters/ModFilter.php @@ -39,6 +39,10 @@ class ModFilter */ private function baseQuery(): Builder { + // TODO: The latestVersion relationship is sometimes null here and it causes issues. We need to ensure that + // empty relationships are filtered out. Normally we would use the whereHas method, but it causes *major* + // performance issues in this case. We need to find a better solution. + return Mod::select([ 'mods.id', 'mods.name',