spt/forge
spt/forge
0
0
Fork 0
mirror of https://github.com/sp-tarkov/forge.git synced 2025-02-12 12:10:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

update scope and tests

Browse Source 
to not include null published at fields
This commit is contained in:
IsWaffle 2024-07-31 14:06:56 -04:00
parent fe280faf36
commit 82a466eb58
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
app/Models/Scopes/PublishedScope.php
View File

@ -14,6 +14,7 @@ class PublishedScope implements Scope
*/
public function apply(Builder $builder, Model $model): void
{
$builder->where($model->getTable().'.published_at', "<=", now());
$builder->whereNotNull($model->getTable().'.published_at')
->where($model->getTable().'.published_at', "<=", now());
}
}

6
tests/Feature/ModVersionTest.php
View File

@ -17,10 +17,10 @@ it('includes only published mod versions', function () {
$mods = ModVersion::all();
expect($mods)->toHaveCount(2);
expect($mods)->toHaveCount(1);
expect($mods->contains($publishedMod))->toBeTrue();
expect($mods->contains($unpublishedMod))->toBeFalse();
expect($mods->contains($noPublishedDateMod))->toBeTrue();
expect($mods->contains($noPublishedDateMod))->toBeFalse();
});
it('handles null published_at as not published', function () {
@ -30,5 +30,5 @@ it('handles null published_at as not published', function () {
$mods = ModVersion::all();
expect($mods->contains($modWithNoPublishDate))->toBeTrue();
expect($mods->contains($modWithNoPublishDate))->toBeFalse();
});