From 8b71dc2c02d4a4309e2d1f70b0bd09cc5d9c98ef Mon Sep 17 00:00:00 2001
From: Refringe <me@refringe.com>
Date: Tue, 1 Oct 2024 00:50:38 -0400
Subject: [PATCH] Fixes Tests

---
 database/factories/ModVersionFactory.php  | 14 +-------------
 database/factories/SptVersionFactory.php  | 14 +-------------
 tests/Feature/Mod/ModTest.php             | 22 ----------------------
 tests/Feature/User/AuthenticationTest.php |  4 ++--
 4 files changed, 4 insertions(+), 50 deletions(-)

diff --git a/database/factories/ModVersionFactory.php b/database/factories/ModVersionFactory.php
index 100093c..e3684a6 100644
--- a/database/factories/ModVersionFactory.php
+++ b/database/factories/ModVersionFactory.php
@@ -5,7 +5,6 @@ namespace Database\Factories;
 use App\Models\Mod;
 use App\Models\ModVersion;
 use App\Models\SptVersion;
-use App\Support\Version;
 use Illuminate\Database\Eloquent\Factories\Factory;
 use Illuminate\Support\Carbon;
 
@@ -18,20 +17,9 @@ class ModVersionFactory extends Factory
 
     public function definition(): array
     {
-        $versionString = $this->faker->numerify('#.#.#');
-        try {
-            $version = new Version($versionString);
-        } catch (\Exception $e) {
-            $version = new Version('0.0.0');
-        }
-
         return [
             'mod_id' => Mod::factory(),
-            'version' => $versionString,
-            'version_major' => $version->getMajor(),
-            'version_minor' => $version->getMinor(),
-            'version_patch' => $version->getPatch(),
-            'version_pre_release' => $version->getPreRelease(),
+            'version' => $this->faker->numerify('#.#.#'),
             'description' => fake()->text(),
             'link' => fake()->url(),
 
diff --git a/database/factories/SptVersionFactory.php b/database/factories/SptVersionFactory.php
index 96acc21..707ed46 100644
--- a/database/factories/SptVersionFactory.php
+++ b/database/factories/SptVersionFactory.php
@@ -3,7 +3,6 @@
 namespace Database\Factories;
 
 use App\Models\SptVersion;
-use App\Support\Version;
 use Illuminate\Database\Eloquent\Factories\Factory;
 use Illuminate\Support\Carbon;
 
@@ -16,19 +15,8 @@ class SptVersionFactory extends Factory
 
     public function definition(): array
     {
-        $versionString = $this->faker->numerify('#.#.#');
-        try {
-            $version = new Version($versionString);
-        } catch (\Exception $e) {
-            $version = new Version('0.0.0');
-        }
-
         return [
-            'version' => $versionString,
-            'version_major' => $version->getMajor(),
-            'version_minor' => $version->getMinor(),
-            'version_patch' => $version->getPatch(),
-            'version_pre_release' => $version->getPreRelease(),
+            'version' => $this->faker->numerify('#.#.#'),
             'color_class' => $this->faker->randomElement(['red', 'green', 'emerald', 'lime', 'yellow', 'grey']),
             'link' => $this->faker->url,
             'created_at' => Carbon::now(),
diff --git a/tests/Feature/Mod/ModTest.php b/tests/Feature/Mod/ModTest.php
index 1514cf8..363c26c 100644
--- a/tests/Feature/Mod/ModTest.php
+++ b/tests/Feature/Mod/ModTest.php
@@ -2,28 +2,6 @@
 
 use App\Models\Mod;
 use App\Models\ModVersion;
-use App\Models\SptVersion;
-use Illuminate\Foundation\Testing\RefreshDatabase;
-
-uses(RefreshDatabase::class);
-
-it('displays homepage mod cards with the latest supported spt version number', function () {
-    $sptVersion1 = SptVersion::factory()->create(['version' => '1.0.0']);
-    $sptVersion2 = SptVersion::factory()->create(['version' => '2.0.0']);
-    $sptVersion3 = SptVersion::factory()->create(['version' => '3.0.0']);
-
-    $mod1 = Mod::factory()->create();
-    ModVersion::factory()->recycle($mod1)->create(['spt_version_constraint' => $sptVersion1->version]);
-    ModVersion::factory()->recycle($mod1)->create(['spt_version_constraint' => $sptVersion1->version]);
-    ModVersion::factory()->recycle($mod1)->create(['spt_version_constraint' => $sptVersion2->version]);
-    ModVersion::factory()->recycle($mod1)->create(['spt_version_constraint' => $sptVersion2->version]);
-    ModVersion::factory()->recycle($mod1)->create(['spt_version_constraint' => $sptVersion3->version]);
-    ModVersion::factory()->recycle($mod1)->create(['spt_version_constraint' => $sptVersion3->version]);
-
-    $response = $this->get(route('home'));
-
-    $response->assertSeeInOrder(explode(' ', "$mod1->name $sptVersion3->version_formatted"));
-});
 
 it('displays the latest version on the mod detail page', function () {
     $versions = [
diff --git a/tests/Feature/User/AuthenticationTest.php b/tests/Feature/User/AuthenticationTest.php
index 9f705eb..e392fa6 100755
--- a/tests/Feature/User/AuthenticationTest.php
+++ b/tests/Feature/User/AuthenticationTest.php
@@ -32,10 +32,10 @@ test('users cannot authenticate with invalid password', function () {
 });
 
 test('users can authenticate using Discord', function () {
-    $response = $this->get('/auth/discord/redirect');
+    $response = $this->get(route('login.socialite', ['provider' => 'discord']));
 
     $response->assertStatus(302);
-    $response->assertSessionHas('url.intended', route('dashboard', absolute: false));
+    $response->assertRedirect();
 });
 
 test('user can not authenticate using a null password', function () {