Rector & PHPStan Changes

This commit is contained in:
Refringe 2025-02-06 10:00:24 -05:00
parent 2d72cf4cbf
commit a7b5c2ccb5
Signed by: Refringe
SSH Key Fingerprint: SHA256:t865XsQpfTeqPRBMN2G6+N8wlDjkgUCZF3WGW6O9N/k
2 changed files with 17 additions and 6 deletions

View File

@ -4,7 +4,11 @@ namespace App\Livewire\Mod;
use App\Models\Mod; use App\Models\Mod;
use App\Models\ModVersion; use App\Models\ModVersion;
use Illuminate\Contracts\View\Factory;
use Illuminate\Contracts\View\View as ContractView;
use Illuminate\Foundation\Application;
use Illuminate\Support\Facades\Log; use Illuminate\Support\Facades\Log;
use Illuminate\View\View;
use Livewire\Attributes\On; use Livewire\Attributes\On;
use Livewire\Component; use Livewire\Component;
@ -22,6 +26,9 @@ class ModerationActionButton extends Component
public bool $isRunning = false; public bool $isRunning = false;
/**
* @var array<string, string>
*/
protected $listeners = ['refreshComponent' => '$refresh']; protected $listeners = ['refreshComponent' => '$refresh'];
public function mount(): void public function mount(): void
@ -29,7 +36,7 @@ class ModerationActionButton extends Component
$this->guid = uniqid('', true); $this->guid = uniqid('', true);
} }
public function render() public function render(): Application|Factory|ContractView|View
{ {
$this->allowActions = ! $this->isRunning; $this->allowActions = ! $this->isRunning;
@ -45,7 +52,7 @@ class ModerationActionButton extends Component
#[On('startAction.{guid}')] #[On('startAction.{guid}')]
public function invokeAction(): void public function invokeAction(): void
{ {
if ($this->moderatedObjectId == null || $this->moderatedObjectId == '') { if (empty($this->moderatedObjectId)) {
Log::info('Failed: no ID specified.'); Log::info('Failed: no ID specified.');
return; return;
@ -61,11 +68,11 @@ class ModerationActionButton extends Component
switch ($this->targetType) { switch ($this->targetType) {
case 'mod': case 'mod':
$moderatedObject = Mod::where('id', '=', $this->moderatedObjectId)->first(); $moderatedObject = Mod::query()->where('id', '=', $this->moderatedObjectId)->first();
break; break;
case 'modVersion': case 'modVersion':
$moderatedObject = ModVersion::where('id', '=', $this->moderatedObjectId)->first(); $moderatedObject = ModVersion::query()->where('id', '=', $this->moderatedObjectId)->first();
break; break;
default: default:
@ -74,7 +81,7 @@ class ModerationActionButton extends Component
return; return;
} }
if ($moderatedObject == null) { if ($moderatedObject === null) {
Log::info('Failed: moderated object is null'); Log::info('Failed: moderated object is null');
return; return;

View File

@ -2,6 +2,10 @@
namespace App\Livewire\Mod; namespace App\Livewire\Mod;
use Illuminate\Contracts\View\Factory;
use Illuminate\Contracts\View\View as ContractView;
use Illuminate\Foundation\Application;
use Illuminate\View\View;
use Livewire\Component; use Livewire\Component;
class ModerationOptions extends Component class ModerationOptions extends Component
@ -18,7 +22,7 @@ class ModerationOptions extends Component
public bool $showDisableDialog = false; public bool $showDisableDialog = false;
public function render() public function render(): Application|Factory|ContractView|View
{ {
return view('livewire.mod.moderation-options'); return view('livewire.mod.moderation-options');
} }