spt/server
spt/server
0
0
Fork 0
mirror of https://github.com/sp-tarkov/server.git synced 2025-02-12 15:50:42 -05:00
Code

Ensure verifyQuestProductionUnlocks() skips quests that cannot be found in db

Browse Source
This commit is contained in:
Chomp 2024-11-30 22:42:02 +00:00
parent e5067b09e5
commit 016fc2a51e
1 changed files with 21 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
project/src/services/ProfileFixerService.ts
View File

@ -280,26 +280,30 @@ export class ProfileFixerService {
const quests = this.databaseService.getQuests();
const profileQuests = pmcProfile.Quests;
for (const profileQuest of profileQuests)
{
for (const profileQuest of profileQuests) {
const quest = quests[profileQuest.qid];
if (!quest) {
continue;
}
// For started or successful quests, check for unlocks in the `Started` rewards
if (profileQuest.status == QuestStatus.Started || profileQuest.status == QuestStatus.Success)
{
const productionRewards = quest.rewards.Started?.filter(reward => reward.type == QuestRewardType.PRODUCTIONS_SCHEME);
productionRewards?.forEach(reward => this.verifyQuestProductionUnlock(pmcProfile, reward, quest));
if (profileQuest.status == QuestStatus.Started || profileQuest.status == QuestStatus.Success) {
const productionRewards = quest.rewards.Started?.filter(
(reward) => reward.type == QuestRewardType.PRODUCTIONS_SCHEME,
);
productionRewards?.forEach((reward) => this.verifyQuestProductionUnlock(pmcProfile, reward, quest));
}
// For successful quests, check for unlocks in the `Success` rewards
if (profileQuest.status == QuestStatus.Success)
{
const productionRewards = quest.rewards.Success?.filter(reward => reward.type == QuestRewardType.PRODUCTIONS_SCHEME);
productionRewards?.forEach(reward => this.verifyQuestProductionUnlock(pmcProfile, reward, quest));
if (profileQuest.status == QuestStatus.Success) {
const productionRewards = quest.rewards.Success?.filter(
(reward) => reward.type == QuestRewardType.PRODUCTIONS_SCHEME,
);
productionRewards?.forEach((reward) => this.verifyQuestProductionUnlock(pmcProfile, reward, quest));
}
}
const validateTime = performance.now() - start
const validateTime = performance.now() - start;
this.logger.debug(`Quest Production Unlock validation took: ${validateTime.toFixed(2)}ms`);
}
@ -308,12 +312,12 @@ export class ProfileFixerService {
* @param pmcProfile Profile to check
* @param productionUnlockReward The quest reward to validate
* @param questDetails The quest the reward belongs to
* @returns
* @returns
*/
protected verifyQuestProductionUnlock(
pmcProfile: IPmcData,
productionUnlockReward: IQuestReward,
questDetails: IQuest
questDetails: IQuest,
): void {
const matchingProductions = this.questHelper.getRewardProductionMatch(productionUnlockReward, questDetails);
if (matchingProductions.length !== 1) {
@ -329,10 +333,11 @@ export class ProfileFixerService {
// Add above match to pmc profile
const matchingProductionId = matchingProductions[0]._id;
if (!pmcProfile.UnlockedInfo.unlockedProductionRecipe.includes(matchingProductionId))
{
if (!pmcProfile.UnlockedInfo.unlockedProductionRecipe.includes(matchingProductionId)) {
pmcProfile.UnlockedInfo.unlockedProductionRecipe.push(matchingProductionId);
this.logger.debug(`Added production ${matchingProductionId} to unlocked production recipes for ${questDetails.QuestName}`);
this.logger.debug(
`Added production ${matchingProductionId} to unlocked production recipes for ${questDetails.QuestName}`,
);
}
}