spt/server
spt/server
0
0
Fork 0
mirror of https://github.com/sp-tarkov/server.git synced 2025-02-13 09:50:43 -05:00
Code

make itemHasBaseClass() more robust against bad input

Browse Source
This commit is contained in:
Dev 2023-10-13 16:54:17 +01:00
parent 8e377594da
commit 292791aca4
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
project/src/services/ItemBaseClassService.ts
View File

@ -1,6 +1,7 @@
import { inject, injectable } from "tsyringe"; import { inject, injectable } from "tsyringe";
import { ITemplateItem } from "../models/eft/common/tables/ITemplateItem"; import { ITemplateItem } from "../models/eft/common/tables/ITemplateItem";
import { BaseClasses } from "../models/enums/BaseClasses";
import { ILogger } from "../models/spt/utils/ILogger"; import { ILogger } from "../models/spt/utils/ILogger";
import { DatabaseServer } from "../servers/DatabaseServer"; import { DatabaseServer } from "../servers/DatabaseServer";
import { LocalisationService } from "./LocalisationService"; import { LocalisationService } from "./LocalisationService";
@ -83,6 +84,19 @@ export class ItemBaseClassService
this.hydrateItemBaseClassCache(); this.hydrateItemBaseClassCache();
} }
if (typeof itemTpl === "undefined")
{
this.logger.warning("Unable to check itemTpl base class as its undefined");
return false;
}
// Edge case - this is the 'root' item that all other items inherit from
if (itemTpl === BaseClasses.ITEM)
{
return false;
}
// No item in cache // No item in cache
if (!this.itemBaseClassesCache[itemTpl]) if (!this.itemBaseClassesCache[itemTpl])
{ {