From 571819906e4d2c3ac9d61210718d4044a665a640 Mon Sep 17 00:00:00 2001 From: Chomp Date: Sat, 14 Dec 2024 09:49:34 +0000 Subject: [PATCH] made `eventId` property inside `IWsNotificationEvent` optional + cleaned up TODO --- project/src/controllers/DialogueController.ts | 2 -- project/src/models/eft/ws/IWsNotificationEvent.ts | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/project/src/controllers/DialogueController.ts b/project/src/controllers/DialogueController.ts index 64236062..6fafc485 100644 --- a/project/src/controllers/DialogueController.ts +++ b/project/src/controllers/DialogueController.ts @@ -479,8 +479,6 @@ export class DialogueController { // We need to delay this so that the friend request gets properly added to the clientside list before we accept it setTimeout(() => { const notification: IWsFriendsListAccept = { - // TODO: eventId isn't necessary, but the interface requires it, so we can use a dummy value. Interface should be updated - eventId: "0", type: NotificationEventType.FRIEND_LIST_REQUEST_ACCEPTED, profile: this.profileHelper.getChatRoomMemberFromPmcProfile(friendProfile.characters.pmc), }; diff --git a/project/src/models/eft/ws/IWsNotificationEvent.ts b/project/src/models/eft/ws/IWsNotificationEvent.ts index 5fc72f3a..de119c8d 100644 --- a/project/src/models/eft/ws/IWsNotificationEvent.ts +++ b/project/src/models/eft/ws/IWsNotificationEvent.ts @@ -1,4 +1,4 @@ export interface IWsNotificationEvent { type: string; - eventId: string; + eventId?: string; }