spt/server
spt/server
0
0
Fork 0
mirror of https://github.com/sp-tarkov/server.git synced 2025-02-13 09:50:43 -05:00
Code

Correctly remove item + children from fence assorts when running removeFenceOffer()

Browse Source
This commit is contained in:
Dev 2024-01-08 11:34:52 +00:00
parent 30507acd1b
commit 96f75fd744
1 changed files with 20 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
project/src/services/FenceService.ts
View File

@ -899,18 +899,28 @@ export class FenceService
*/
public removeFenceOffer(assortIdToRemove: string): void
{
let relatedAssortIndex = this.fenceAssort.items.findIndex((i) => i._id === assortIdToRemove);
// No offer found in main assort, check discount items
if (relatedAssortIndex === -1)
// Assort could have child items, remove those too
const itemWithChildrenToRemove = this.itemHelper.findAndReturnChildrenAsItems(this.fenceAssort.items, assortIdToRemove);
for (const itemToRemove of itemWithChildrenToRemove)
{
relatedAssortIndex = this.fenceDiscountAssort.items.findIndex((i) => i._id === assortIdToRemove);
this.fenceDiscountAssort.items.splice(relatedAssortIndex, 1);
let indexToRemove = this.fenceAssort.items.findIndex(item => item._id === itemToRemove._id);
return;
// No offer found in main assort, check discount items
if (indexToRemove === -1)
{
indexToRemove = this.fenceDiscountAssort.items.findIndex((i) => i._id === itemToRemove._id);
this.fenceDiscountAssort.items.splice(indexToRemove, 1);
if (indexToRemove === -1)
{
this.logger.warning(`unable to remove fence assort item: ${itemToRemove._id} tpl: ${itemToRemove._tpl}`)
}
return;
}
// Remove offer from assort
this.fenceAssort.items.splice(indexToRemove, 1);
}
// Remove offer from assort
this.fenceAssort.items.splice(relatedAssortIndex, 1);
}
}