spt/server
spt/server
0
0
Fork 0
mirror of https://github.com/sp-tarkov/server.git synced 2025-02-13 01:30:44 -05:00
Code

Added nullgaurd to getQuestRewardItems() to protect against invalid custom quests

Browse Source
This commit is contained in:
Chomp 2024-12-03 16:50:54 +00:00
parent a16aaf270f
commit 9b7c31e36f
1 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
project/src/helpers/QuestHelper.ts
View File

@ -358,9 +358,16 @@ export class QuestHelper {
* @returns array of items with the correct maxStack * @returns array of items with the correct maxStack
*/ */
public getQuestRewardItems(quest: IQuest, status: QuestStatus, gameVersion: string): IItem[] { public getQuestRewardItems(quest: IQuest, status: QuestStatus, gameVersion: string): IItem[] {
if (!quest.rewards[QuestStatus[status]]) {
this.logger.warning(`Unable to find: ${status} reward for quest: ${quest.QuestName}`);
return [];
}
// Iterate over all rewards with the desired status, flatten out items that have a type of Item // Iterate over all rewards with the desired status, flatten out items that have a type of Item
const questRewards = quest.rewards[QuestStatus[status]].flatMap((reward: IQuestReward) => const questRewards = quest.rewards[QuestStatus[status]].flatMap((reward: IQuestReward) =>
reward.type === "Item" && this.questRewardIsForGameEdition(reward, gameVersion) ? this.processReward(reward) : [], reward.type === "Item" && this.questRewardIsForGameEdition(reward, gameVersion)
? this.processReward(reward)
: [],
); );
return questRewards; return questRewards;