From b645e6f51b124b8ecdf82e3af5cd88b2adc14350 Mon Sep 17 00:00:00 2001 From: Dev Date: Sat, 8 Jun 2024 12:56:24 +0100 Subject: [PATCH] Added Error throwing when calling `getConfig()` and a config cannot be found --- project/src/helpers/TradeHelper.ts | 3 ++- project/src/servers/ConfigServer.ts | 5 +++++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/project/src/helpers/TradeHelper.ts b/project/src/helpers/TradeHelper.ts index bfe7f2a2..96b5fdfc 100644 --- a/project/src/helpers/TradeHelper.ts +++ b/project/src/helpers/TradeHelper.ts @@ -142,12 +142,13 @@ export class TradeHelper { // Update assort/flea item values const traderAssorts = this.traderHelper.getTraderAssortsByTraderId(buyRequestData.tid).items; - const itemPurchased = traderAssorts.find((x) => x._id === buyRequestData.item_id); + const itemPurchased = traderAssorts.find((item) => item._id === buyRequestData.item_id); // Ensure purchase does not exceed trader item limit const assortHasBuyRestrictions = this.itemHelper.hasBuyRestrictions(itemPurchased); if (assortHasBuyRestrictions) { + // Will throw error if check fails this.checkPurchaseIsWithinTraderItemLimit( sessionID, buyRequestData.tid, diff --git a/project/src/servers/ConfigServer.ts b/project/src/servers/ConfigServer.ts index 03c8e1ec..61f98760 100644 --- a/project/src/servers/ConfigServer.ts +++ b/project/src/servers/ConfigServer.ts @@ -21,6 +21,11 @@ export class ConfigServer public getConfig(configType: ConfigTypes): T { + if (!this.configs[configType]) + { + throw new Error(`Config: ${configType} is undefined. Ensure you have not broken it via editing`); + } + return this.configs[configType]; }