From c20a9d6e369d6139168213ab108e8c218ca395ee Mon Sep 17 00:00:00 2001 From: Dev Date: Sun, 23 Apr 2023 11:25:42 +0100 Subject: [PATCH] FIx getFleaPriceForItem() not logging when price was not found --- project/src/services/RagfairPriceService.ts | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/project/src/services/RagfairPriceService.ts b/project/src/services/RagfairPriceService.ts index 667f970e..02dcab9a 100644 --- a/project/src/services/RagfairPriceService.ts +++ b/project/src/services/RagfairPriceService.ts @@ -97,16 +97,14 @@ export class RagfairPriceService implements OnLoad public getFleaPriceForItem(tplId: string): number { // Get dynamic price (templates/prices), if that doesnt exist get price from static array (templates/handbook) - let itemPrice = this.getDynamicPriceForItem(tplId); - if (!itemPrice || itemPrice === 1) - { - itemPrice = this.getStaticPriceForItem(tplId); - } + let itemPrice = this.getDynamicPriceForItem(tplId) || this.getStaticPriceForItem(tplId); - if (!itemPrice) + // If no price in dynamic/static, set to 1 + itemPrice = itemPrice || 1; + + if (itemPrice === 1) { this.logger.debug(`Missing item price for ${tplId}`); - itemPrice = 1; } return itemPrice;