4144fccbd1
Complete issues #667 (Possible issue with flea buying) ( !382 )
...
Now when a profile create a new offer and another profile buy it, it can work correctly(For example profile A create a offer and profile B buy this offer, now A will receive money from profile B)
and set RagfairOfferHelper.completeOffer to public because TradeHelper now use it to resolve trade between 2 profiles on ragfair
Reviewed-on: SPT/Server#382
Co-authored-by: HiddenCirno <2301697863@qq.com>
Co-committed-by: HiddenCirno <2301697863@qq.com>
(cherry picked from commit f555c24709bd4ed9b294c1e008ce3229be4190e1)
2024-07-21 16:17:29 +01:00
f555c24709
Complete issues #667 (Possible issue with flea buying) ( !382 )
...
Now when a profile create a new offer and another profile buy it, it can work correctly(For example profile A create a offer and profile B buy this offer, now A will receive money from profile B)
and set RagfairOfferHelper.completeOffer to public because TradeHelper now use it to resolve trade between 2 profiles on ragfair
Reviewed-on: SPT/Server#382
Co-authored-by: HiddenCirno <2301697863@qq.com>
Co-committed-by: HiddenCirno <2301697863@qq.com>
2024-07-21 15:05:48 +00:00
Dev
3f43e3f118
Localised error message
...
(cherry picked from commit 335806bfd8e9c4d84818a978f7fcd9b5f6f41750)
2024-07-21 09:10:24 +01:00
Dev
335806bfd8
Localised error message
2024-07-20 13:44:48 +01:00
Dev
3f7f357bff
Improved getTotalStackCountSize
...
(cherry picked from commit bd5e7b1e62e86b426392d6be4c209c8b9e45095f)
2024-07-18 09:25:04 +01:00
Dev
bd5e7b1e62
Improved getTotalStackCountSize
2024-07-17 20:17:12 +01:00
Dev
5e3899c426
Improved fillMagazineWithRandomCartridge() logging
...
(cherry picked from commit f406918bb8bf418ad32daabb947e1004282c1f0b)
2024-07-17 12:44:24 +01:00
Dev
f406918bb8
Improved fillMagazineWithRandomCartridge() logging
2024-07-17 11:48:57 +01:00
Dev
373f194a25
Fixed items with a stack count > 1 not selling as expected
...
(cherry picked from commit fd34e7bc8412b0ce0503691b984256b57a14383e)
2024-07-16 21:09:08 +01:00
Dev
fd34e7bc84
Fixed items with a stack count > 1 not selling as expected
2024-07-16 21:08:43 +01:00
Dev
bf8a403372
Removed redundant check on unlocking hideout crafts
...
(cherry picked from commit 433ea6566ac562bc5cca16b5082fa6d76a0ee86b)
2024-07-16 11:59:01 +01:00
Dev
433ea6566a
Removed redundant check on unlocking hideout crafts
2024-07-16 11:32:46 +01:00
c46cdaeb18
Don't allow production timers to be reduced below 5 seconds ( !375 )
...
This should avoid potential issues when mods drastically increase the crafting skill level, or otherwise modify the profile in ways that cause negative production times
Co-authored-by: DrakiaXYZ <565558+TheDgtl@users.noreply.github.com>
Reviewed-on: SPT/Server#375
Co-authored-by: DrakiaXYZ <drakiaxyz@noreply.dev.sp-tarkov.com>
Co-committed-by: DrakiaXYZ <drakiaxyz@noreply.dev.sp-tarkov.com>
2024-07-15 19:33:38 +00:00
50bafeb100
Fix flea selling issues ( !374 )
...
Co-authored-by: Dev <dev@dev.sp-tarkov.com>
Reviewed-on: SPT/Server#374
(cherry picked from commit 4fd113d00dda4a5e9e3f26d551bd8904156d1086)
2024-07-15 19:24:53 +01:00
4fd113d00d
Fix flea selling issues ( !374 )
...
Co-authored-by: Dev <dev@dev.sp-tarkov.com>
Reviewed-on: SPT/Server#374
2024-07-15 18:24:23 +00:00
Dev
2ea6b658fd
Fixed getBTC() failing when Production area cannot be found
...
(cherry picked from commit 77b42bfb2f0540c0fcb4c60fb84cdbcacd0965ad)
2024-07-13 10:59:03 +01:00
Dev
77b42bfb2f
Fixed getBTC() failing when Production area cannot be found
2024-07-13 10:58:46 +01:00
Dev
61313dce25
Remove deprecated registerCommandoCommand()
...
(cherry picked from commit c705127007f0e2f6c501a9ae7f84cd3e824a919d)
2024-07-12 22:21:15 +01:00
Dev
bf507a766c
Removed deprecated ICommandoCommand
...
(cherry picked from commit 28593d3e9b82d89c3ae60b8cbba8c69c4e78f09e)
2024-07-12 22:21:01 +01:00
Dev
c705127007
Remove deprecated registerCommandoCommand()
2024-07-12 22:19:57 +01:00
Dev
28593d3e9b
Removed deprecated ICommandoCommand
2024-07-12 22:19:04 +01:00
4eeedc4257
Removed unused code and repurposed save endpoint for scav profile saving
2024-07-12 16:29:21 +01:00
Dev
b0a65cac7f
Fixed server build errors from previously merged PR
...
(cherry picked from commit e1ca9dedc99e846d9355255935c8688dfa6815b0)
2024-07-11 09:29:16 +01:00
Dev
e1ca9dedc9
Fixed server build errors from previously merged PR
2024-07-11 09:28:37 +01:00
Dev
007bdccd6c
Improved pack + multi-item player flea offer handling
...
(cherry picked from commit e9d8c02ac2d15ae80ab8b22d5db5ac22597b05e7)
2024-07-10 11:40:12 +01:00
Dev
e9d8c02ac2
Improved pack + multi-item player flea offer handling
2024-07-10 11:39:11 +01:00
Dev
2050880c91
Cleanup of getOwnerInventoryItems()
2024-07-09 09:56:18 +01:00
bb50998e04
Skip moving item if item cannot be found.
2024-07-09 09:52:58 +01:00
Dev
007b1d4789
Fixed accepting a quest bringing in blacklisted event quests
...
(cherry picked from commit fe614ad73f69e5f74407bb8ea840e836510237cd)
2024-07-08 09:56:34 +01:00
Dev
fe614ad73f
Fixed accepting a quest bringing in blacklisted event quests
2024-07-08 09:55:56 +01:00
Dev
3288c04a25
Improved post-raid handling of scav raids + btr item service
2024-07-07 21:51:24 +01:00
Dev
6cac4394c1
Depreciated functions
2024-07-07 21:17:10 +01:00
Dev
bda69a5563
Added getMoneyTpls()
2024-07-07 19:43:32 +01:00
b4a5556d14
Fix health saving
2024-07-05 14:39:21 +01:00
Dev
7e64a4be66
Further improvements to post-raid event handling
2024-07-05 13:32:46 +01:00
Dev
5f280612c4
Update interface to correct naming scheme
2024-07-05 09:39:01 +01:00
e58ddac0cc
Fix InventoryHelper.canPlaceItemInContainer being backwards ( !367 )
...
For whatever reason, `InventoryHelper.canPlaceItemInContainer()` currently returns:
`true` if the item CANNOT be placed in the container
`undefined` if the item CAN be placed
`false` if the function thought it could but then failed when trying to (never happens?)
This didn't cause problems because the only two places that call it also treat the return value backwards - both of which are also fixed in this PR.
Reviewed-on: SPT/Server#367
Co-authored-by: Tyfon <tyfon7@outlook.com>
Co-committed-by: Tyfon <tyfon7@outlook.com>
2024-07-02 22:05:32 +00:00
Dev
c8f08ff2bc
Fixed edge case where rigs with no soft inserts or plates is listed on flea, resulting on a sell chance of NaN
2024-07-01 16:37:14 +01:00
Dev
8517e46ccb
Refactored various functions to improve readability
2024-06-30 21:39:58 +01:00
Dev
15eb6eb69f
Cleaned up various functions to improve readability
...
Removed unused function `splitStackIntoSmallerChildStacks()`
2024-06-30 20:38:23 +01:00
da955f0a4e
Added ability to convert assault scavs to bosses ( !366 )
...
Co-authored-by: Kaeno <kaeno@noreply.dev.sp-tarkov.com>
Co-authored-by: Dev <dev@dev.sp-tarkov.com>
Reviewed-on: SPT/Server#366
2024-06-27 14:09:26 +00:00
Dev
836df0ce9d
Updated findAndAddHideoutProductionIdToProfile() to also compare the quest id when finding the relevant craft - should fix craft unlock error with Network Provider - Part 2
2024-06-24 22:29:01 +01:00
Dev
2a750a9989
Fixed regression where sellchance because NaN due to a divide by 0 error
2024-06-22 20:40:13 +01:00
Dev
cf5411336f
Adjusted how item quality % is calculated for player flea offers. Now excludes items without any quality modifier from calculation instead of assuming 100% (slightly lowers sell chance of things like armors)
...
Renamed `getItemQualityModifierForOfferItems()` to `getItemQualityModifierForItems()`
2024-06-19 14:27:58 +01:00
Dev
43a09c29c2
Improved import consistency + comment improvements
...
Moved `IGenerateEquipmentProperties` into own file
2024-06-19 11:11:28 +01:00
Dev
e176b0ae45
Refactored applyMoneyBoost() to improve readability + apply alteration to reward.value
2024-06-17 17:45:48 +01:00
Dev
996e567959
Added nullguard to getTimeElapsedSinceLastServerTick()
2024-06-17 16:43:12 +01:00
Dev
86380e845a
Replaced hard-coded lavatory check for generic check of areas needsFuel property
2024-06-17 09:28:59 +01:00
Dev
4094b7ecff
Fixed getAccountTypeAdjustedTraderPurchaseLimit() not applying to unheard profiles
...
Created `GameVersions` enum and replaced all magic strings with it
2024-06-16 21:22:28 +01:00
Dev
e793b0bc63
Fixed nullref error on repeatable refresh click event
...
Fixed all profiles having access to free repeatable refreshes
Fixed newly created profiles generating with 0 free refreshes regardless of game version
2024-06-16 10:58:35 +01:00
