2aa0054833
Insurance Package Removal Issue
...
Resolved an issue that caused insurance packages that were created/lost in the same raid with different traders to be removed all at once instead of one-by-one after they were processed. This shouldn't have been causing any notable issues as the packages were already cached/queued up for processing elsewhere in the code, but it was never the original intent to have them removed before they were processed. The fix was simply to also match the trader ID when the package removal takes place.
Possibly related to #401 #425
2024-02-06 20:08:14 -05:00
6714d2d172
Forgot Instance of Parent Update
...
Updates the `replaceIDs` method call in the `LocationGenerator` class to be inline with the changes in the parent commit.
2024-02-06 18:50:42 -05:00
42dabc057b
Improved replaceIDs Method in ItemHelper
...
- Implemented deep cloning of input Items to prevent mutation.
- Reordered parameters: Items (required) now precede PMC data (optional).
- Updated method calls to bring them inline with these changes.
2024-02-06 18:39:06 -05:00
c29482394b
(More) Simple Parameter Reassignment Issues
...
Addresses some of the simple linting errors regarding the reassignment of function parameters.
2024-02-06 18:35:11 -05:00
Dev
d8fe911464
Cleanup dynamic loot selection, armors have their children stored in loose loot json, use existing code to pull children out instead of generating it
2024-02-06 23:17:41 +00:00
Dev
cb10ec4148
When generating armors for static loot, try and use default preset first before generating randomly
2024-02-06 23:00:39 +00:00
Dev
1101927768
Improve fence price calculation code. Prices now take into account removed item mods + mod durability
2024-02-06 20:44:40 +00:00
Dev
b40e41bd3d
Improve sellChance logic
...
Two changes:
Calcualte the quality of an item and its mods, not just root item
Calcualte the average price of an offer using item + mods, not just root item
2024-02-06 15:52:22 +00:00
Dev
5f873e73b8
Move handbook override code into HandbookHelper.hydrate() - changes now apply to ragfair
2024-02-06 12:52:56 +00:00
Dev
62f51be3aa
Improve readability of valid item check
2024-02-06 12:18:41 +00:00
Dev
7bc9fdbe95
Add system to override handbook price, add christmas gift items small/med/large
2024-02-06 12:16:26 +00:00
Dev
72345abb4a
Force plates to spawn in armor items found inside PMC backpacks
2024-02-06 10:53:08 +00:00
Dev
ddac44f79d
Divide roubles calculated inside calculateCostOfScavInventoryAndMailMoneyToPlayer() by half
2024-02-06 10:33:59 +00:00
Dev
023697ed74
Partial fix for items flagged as being never lost on death coming back as insurance.
...
Items will not return but plates inside them still do
2024-02-06 10:10:56 +00:00
Dev
c6de12e6f8
Rename variables/comments for clarity
2024-02-06 09:49:51 +00:00
807ba04967
Resolves Bot Generation Error
...
- Resolves an issue in bot generation caused by a missing parameter when calling the `shouldModBeSpawned` method.
- Adds a optional chaining operator within a condition to safeguard against undefined errors.
Contributed by: barlog_m
Thank you! :D
2024-02-05 19:16:36 -05:00
cd6e40b66c
Error Message Propagation Issue
...
Resolves an issue where the error message in `getItemsToListOnFleaFromInventory` did not propagate as expected due to the pass-by-value behaviour in JavaScript. The solution was to refactor the method to return an object that includes both the items and the error message.
2024-02-05 19:03:26 -05:00
3a2b24b9b8
Simple Parameter Reassignment Issues
...
Addresses some of the more simple linting errors regarding the reassignment of function parameters.
2024-02-05 19:03:26 -05:00
34121182a1
Biome Linting Issues
...
Fixed some instances of:
- Unordered imports
- Reassigning function parameters
- Modifying values in assignment/return statements
- Array.forEach being used instead of for...of
- Simplified control logic
2024-02-05 19:03:26 -05:00
Dev
b7d74f1dec
Add system to flag weapon slot ids as required.
...
Applies to stocks/recievers for PMCs
recievers for exusec/raider
2024-02-05 22:02:03 +00:00
Dev
32862866aa
Remove some debug logging
2024-02-05 19:53:59 +00:00
Dev
d36593ca57
Rework fence service to handle armor/weapons separately,
...
made config work with a weapon/equipment min/max value
Improve price filtering system to work with weapons/equipment
2024-02-05 19:52:46 +00:00
Dev
3653ab9f83
Apply a duribility price modifier to items sold on flea
2024-02-05 19:49:42 +00:00
Dev
ce27f58664
FIx weapons/armors not showing on fence
2024-02-05 18:21:02 +00:00
Dev
422b7878ab
Add getMatchingPreset() and add workaround for silenced DVL choosing wrong barrel mods
2024-02-05 15:36:05 +00:00
Dev
a04a05996d
Adjust calculateFenceStandingChangeFromKills() to take into account rep loss when fence rep between 6 and 8 or rep > 8
2024-02-05 14:44:31 +00:00
Dev
bf5f3316b1
Rename cloned variables to help with readability
2024-02-05 14:43:46 +00:00
Dev
183e71370a
Reworked buyItem() to use addItemsToStash() to ensure it performs a space check prior to adding any items to stash
2024-02-05 14:07:21 +00:00
Dev
2f673d12b9
Improve weapon/equipment item purchase filtering
2024-02-05 11:38:04 +00:00
Dev
0f6b34605b
Prevent duplicate equipment builds occuring when renaming an existing build
2024-02-05 09:13:37 +00:00
Dev
946172d20c
Add additional helmet soft inserts to getSoftInsertSlotIds()
2024-02-05 09:02:58 +00:00
Dev
a2668a9618
Rework insurance to not duplicate items + still return soft_inserts
...
Added missing groin_back to `itemRequiresSoftInserts()`
2024-02-04 22:41:11 +00:00
Dev
d9bcb3fce8
Fix deleting an item from mail before receiving all kills server
2024-02-04 19:51:19 +00:00
Dev
9fa0bf53e5
Rework sell all scav gear button to send money as mail
2024-02-04 19:27:35 +00:00
Dev
63603f5d9a
Reduce grizzly count added to PMC secure to 1 + morphine to 2
2024-02-04 14:43:37 +00:00
Dev
cfe470029f
Refactor insurance item checking code into 2 functions to allow checking if any items were lost before sending Insurance lost mail
2024-02-04 10:19:57 +00:00
Dev
afce41d68b
Improve lost insurance message system, only send lost insurance when an insured item was lost
2024-02-04 09:52:56 +00:00
Dev
193161f786
Fix preset buy searches not filtering items based on search criteria/player level
2024-02-04 09:31:00 +00:00
Dev
2c4278cd96
Show debug message as warning + fix incorrect prapor quest assort ids
2024-02-04 09:12:27 +00:00
Dev
f2ed957579
Expand server version debug logging
2024-02-04 09:04:12 +00:00
Dev
4d88b2a94a
Prevent developer profile changes bleeding into non-dev accounts
2024-02-03 23:40:20 +00:00
Dev
3dacbc98b2
Remove redundant .some() call
2024-02-03 23:11:36 +00:00
Dev
d362e17e1b
prevent failQuest() from failing when no repeatable quest is found
2024-02-03 23:10:42 +00:00
Dev
714386c793
Update generateEquipment() to return true when it adds item
2024-02-03 20:29:31 +00:00
Dev
3c371a6c16
Add search criteria filtering to required search
...
Pull out`isDisplayableOffer` from`passesSearchFilterCriteria`
2024-02-03 20:23:26 +00:00
Dev
36d6e56d89
Improve comments
2024-02-03 19:47:39 +00:00
Dev
747510e5d2
Remove bleeds/breaks after 30 mins offline
2024-02-03 19:45:42 +00:00
Dev
1a9dc1ea2b
Cleanup of setHideoutAreasAndCraftsTo40Secs to more central location
2024-02-03 19:42:49 +00:00
Dev
ec9a877cd4
Force item limits to be used with special loot items
2024-02-03 17:34:08 +00:00
Dev
fcd7e463aa
Merge branch '3.8.0' of https://dev.sp-tarkov.com/SPT-AKI/Server into 3.8.0
2024-02-03 17:00:04 +00:00
