WIP: Allow using _parent Ids to set prices for a group of items #4

Closed
egbog wants to merge 2 commits from (deleted):main into main
2 changed files with 6 additions and 1 deletions
Showing only changes of commit d44b857b46 - Show all commits

View File

@ -25,6 +25,11 @@
// You can manually add flea prices to items, set a multiplier to their existing price or blacklist them entirely.
"customItemConfigs": [
{
// Headwear parent id, this fixes all blacklisted helmets having extremely low prices on flea
"itemId": "5a341c4086f77401f2541505",
"priceMultiplier": 12
},
{
// .338 AP round, the best round in the game so it's quite expensive. This also demonstrates the use of the priceMultiplier property. You can lower this if you think it's too expensive.",
"itemId": "5fc382a9d724d907e2077dab",

View File

@ -71,7 +71,7 @@ class TheBlacklistMod implements IPostDBLoadModAsync {
const item = itemTable[handbookItem.Id];
const originalPrice = prices[item._id];
const customItemConfig = this.config.customItemConfigs.find(conf => conf.itemId === item._id);
const customItemConfig = this.config.customItemConfigs.find(conf => conf.itemId === item._id || conf.itemId == item._parent);
Review

First of all, thanks for contributing to my mod. I think this feature addition is valuable.

I would suggest we use a new property for this check. Instead of using itemId in the json config, let's rename to it parentId. Then you'll have || conf.parentId == item._parent); here.

First of all, thanks for contributing to my mod. I think this feature addition is valuable. I would suggest we use a new property for this check. Instead of using itemId in the json config, let's rename to it `parentId`. Then you'll have `|| conf.parentId == item._parent);` here.
// We found a custom item config override to use. That's all we care about for this item. Move on to the next item.
if (customItemConfig && this.updateItemUsingCustomItemConfig(customItemConfig, item, prices, originalPrice, ragfairConfig)) {