Platinum/the-blacklist
Platinum/the-blacklist
0
0
Fork 0
Code Issues Pull Requests Projects Releases 9 Wiki Activity

WIP: Allow using _parent Ids to set prices for a group of items #4

Closed
egbog wants to merge 2 commits from (deleted):main into main
pull from: (deleted):main
merge into: Platinum:main
Conversation 1 Commits 2 Files Changed 2 +6 -1
egbog commented 2024-10-24 02:25:54 -04:00
Contributor
Copy Link

Primarily used for fixing the extremely low prices for blacklisted helmets due to handbook prices being out of wack.

Ie. Team Wendy EXFIL Ballistic Helmet (Coyote Brown) has a handbook price of 5068, leading flea price to be
(5068 * handbookPriceMultiplier) = 15204 by default

Primarily used for fixing the extremely low prices for blacklisted helmets due to handbook prices being out of wack. Ie. Team Wendy EXFIL Ballistic Helmet (Coyote Brown) has a handbook price of 5068, leading flea price to be (5068 * handbookPriceMultiplier) = 15204 by default
egbog added 1 commit 2024-10-24 02:25:54 -04:00 
Primarily used for fixing the extremely low prices for blacklisted helmets due to handbook prices being out of wack.

Ie. Team Wendy EXFIL Ballistic Helmet (Coyote Brown) has a price of 5068, leading flea price to be
(5068 * handbookPriceMultiplier) = 15204
egbog started working 2024-10-25 16:08:16 -04:00
egbog worked for 5 seconds 2024-10-25 16:08:21 -04:00
egbog deleted spent time 2024-10-25 16:08:26 -04:00
- 5 seconds
Platinum requested changes 2024-11-27 04:31:30 -05:00
src/mod.ts
@ -72,3 +72,3 @@
const originalPrice = prices[item._id];
const customItemConfig = this.config.customItemConfigs.find(conf => conf.itemId === item._id);
const customItemConfig = this.config.customItemConfigs.find(conf => conf.itemId === item._id || conf.itemId == item._parent);
Platinum commented 2024-11-27 04:30:22 -05:00
Owner
Copy Link

First of all, thanks for contributing to my mod. I think this feature addition is valuable.

I would suggest we use a new property for this check. Instead of using itemId in the json config, let's rename to it parentId. Then you'll have || conf.parentId == item._parent); here.

First of all, thanks for contributing to my mod. I think this feature addition is valuable. I would suggest we use a new property for this check. Instead of using itemId in the json config, let's rename to it `parentId`. Then you'll have `|| conf.parentId == item._parent);` here.
egbog changed title from Allow using _parent Ids to set prices for a group of items to WIP: Allow using _parent Ids to set prices for a group of items 2024-11-28 00:00:46 -05:00
egbog added 1 commit 2024-11-28 00:08:59 -05:00 
Reviewed-on: egbog/the-blacklist#1
egbog closed this pull request 2024-11-28 00:16:15 -05:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Platinum
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Platinum/the-blacklist#4
No description provided.
Delete Branch "(deleted):main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?