return 204 response if search has empty result

This commit is contained in:
Rev 2021-10-11 16:00:49 +09:00
parent 54565ff4b7
commit 7549f164ae

View File

@ -27,9 +27,16 @@ class ItemController extends Controller
*/ */
public function search(Request $request): JsonResponse public function search(Request $request): JsonResponse
{ {
return response()->json([ $status = Response::HTTP_NO_CONTENT;
'item' => $this->itemsCollection->findItem($request->input('query')), $result = $this->itemsCollection->findItem($request->input('query'));
]); $response = [];
if ($result->isNotEmpty()) {
$status = Response::HTTP_OK;
$response = [
'items' => $result->toArray(),
];
}
return response()->json($response, $status);
} }
/** /**